Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add smoke tests para inclusion #756

Merged
merged 6 commits into from
Nov 22, 2024
Merged

Add smoke tests para inclusion #756

merged 6 commits into from
Nov 22, 2024

Conversation

tmpolaczyk
Copy link
Contributor

@tmpolaczyk tmpolaczyk commented Nov 19, 2024 •
edited
Loading

Tests:

  • Whenever a parachain candidate is found, there exist collators associated to it (otherwise they would not have “core allocation”).
  • Whenever a para candidate is found, its context parent should be at most allowedAncestryLen. By this we mean that the relay parent should be at most allowedAncestryLen backwards.
  • The number of para candidates injected does not surpass the number of cores.

tmpolaczyk
tmpolaczyk commented Nov 19, 2024
View reviewed changes
test/moonwall.config.json Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited
Loading

WASM runtime size check:

Compared to target branch

dancebox runtime: 1412 KB (no changes) ✅

flashbox runtime: 832 KB (no changes) ✅

dancelight runtime: 2008 KB (+2008 KB) ⚠️

container chain template simple runtime: 1088 KB (-4224 KB) ✅

container chain template frontier runtime: 1388 KB (-5136 KB) ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited
Loading

Coverage Report

(master)

@@                         Coverage Diff                         @@
##           master   tomasz-smoke-test-para-inclusion     +/-   ##
===================================================================
  Coverage   65.34%                             65.34%   0.00%     
  Files         310                                310             
  Lines       54174                              54174             
===================================================================
  Hits        35395                              35395             
  Misses      18779                              18779
Files Changed Coverage

Coverage generated Thu Nov 21 15:51:53 UTC 2024

@tmpolaczyk tmpolaczyk added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes labels Nov 20, 2024
girazoki
girazoki approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

@tmpolaczyk tmpolaczyk merged commit af56b58 into master Nov 22, 2024
42 checks passed
@tmpolaczyk tmpolaczyk deleted the tomasz-smoke-test-para-inclusion branch November 22, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girazoki girazoki girazoki approved these changes

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmpolaczyk @girazoki